Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cob_hardware_config: added laser-calibration data for raw3-3 #299

Closed

Conversation

fmirus
Copy link

@fmirus fmirus commented May 11, 2015

needs ipa320/cob_common#156 and ipa320/cob_calibration_data#80

@fmessmer
Copy link
Member

I see the need for this, however, I have some concerns about the way it is done...
The main problem is the way our base.xacro's are provided in our description packages, i.e. that the scanners are (hardcoded) parts of the bases without a chance of providing calibration/mounting parameters to them.

In particular, this line somewhat introduces a dependency from cob_common to cob_robots....which is undesirable!

As we had in mind to restructure the base.xacro's anyway in the near future (e.g. provide separate xacros for the IPA Fahrdrehmodul instead of having the ancient PR2-wheel-based xacro), the calibration aspect for the laser scanner should be considered then, too.

In addition, as a minor comment, I would prefer to have full 6D calibration properties, i.e. x,y,z,roll,pitch,yaw rather than only x,y,yaw - even if z,roll and pitch are 0.0 for now...

@fmessmer
Copy link
Member

I created an issue to record this: https://github.com/ipa320/cob_common/issues/157

@fmessmer
Copy link
Member

fmessmer commented Jun 3, 2015

do not merge - superseded by #305

@ipa-frm

@floweisshardt
Copy link
Member

integrated into #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants